[tune/air] Exclude files in sync_dir_between_nodes, exclude temporary checkpoints #27174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 28, 2022 15:03
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
4 tasks
xwjiang2010
reviewed
Jul 28, 2022
python/ray/tune/syncer.py
Outdated
| @@ -39,6 +39,8 @@ | |||
| # Syncing period for syncing checkpoints between nodes or to cloud. | |||
| DEFAULT_SYNC_PERIOD = 300 | |||
|
|
|||
| _EXCLUDE_FROM_SYNC = ["./checkpoint_-00001", "./checkpoint_tmp*", "./save_to_object*"] | |||
7 tasks
Signed-off-by: Kai Fricke <kai@anyscale.com>
xwjiang2010
approved these changes
Jul 28, 2022
krfricke
added a commit
to krfricke/ray
that referenced
this pull request
Jul 28, 2022
… checkpoints (ray-project#27174) Currently Tune sometimes syncs temporary (and thus ephemeral) checkpoint directories to the driver. This is unnecessary and should be avoided. This PR 1. Add an `exclude` argument to `sync_dir_between_nodes` to exclude files based on pattern matching 2. Adds three default patterns to exclude in node-to-driver syncing 3. Adds tests for all these utilities Signed-off-by: Kai Fricke <kai@anyscale.com> # Conflicts: # python/ray/tune/tests/test_syncer_callback.py
7 tasks
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
… checkpoints (ray-project#27174) Currently Tune sometimes syncs temporary (and thus ephemeral) checkpoint directories to the driver. This is unnecessary and should be avoided. This PR 1. Add an `exclude` argument to `sync_dir_between_nodes` to exclude files based on pattern matching 2. Adds three default patterns to exclude in node-to-driver syncing 3. Adds tests for all these utilities Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently Tune sometimes syncs temporary (and thus ephemeral) checkpoint directories to the driver. This is unnecessary and should be avoided. This PR
excludeargument tosync_dir_between_nodesto exclude files based on pattern matchingRelated issue number
Closes #27171
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.