[RLlib] Remove unneeded args from offline learning examples #26666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
…apex test Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
This comment is directed at another PR that moves the learning_starts parameters but needed to be merged into this one because they interfere. The comment has been resolved in the other PR. |
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
| @@ -262,7 +262,7 @@ def training( | |||
| if grad_clip is not None: | |||
| self.grad_clip = grad_clip | |||
| if optimization_config is not None: | |||
| self.optimization_config = optimization_config | |||
kouroshHakha
approved these changes
Aug 15, 2022
|
Hey @gjoliver , could you approve this, so it can be merged, now that questions have been addressed? |
This comment is directed at another PR that moves the learning_starts parameters but needed to be merged into this one because they interfere. The comment has been resolved in the other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We largely got rid of replay buffers in the context of offline RL in RLlib, but the examples have not beed changed.
This PR gets the offline learning example back on track.
#26665
Checks
scripts/format.shto lint the changes in this PR.