Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR/CI] Fix Hugging Face notebook example #26475

Merged

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 12, 2022

Signed-off-by: Antoni Baum antoni.baum@protonmail.com

Why are these changes needed?

Fixes the Hugging Face notebook example as found in #26410

The issue was caused by the cells sharing the model to Hugging Face hub. This is not something we should test. In order to skip those cells, a postprocessing step has been added to test_myst_doc.py script we are using to convert jupyter notebooks to remove any cell with remove-cell-ci tag present in metadata, so that it is not executed in CI but still rendered in docs.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Yard1 added 5 commits July 12, 2022 19:01
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardliaw richardliaw merged commit 5ed10ef into ray-project:master Jul 13, 2022
@Yard1 Yard1 deleted the fix_huggingface_notebook_example branch July 13, 2022 16:23
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants