Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Cherry pick streaming generator PRs #35634

Closed
9 tasks done
rkooo567 opened this issue May 22, 2023 · 8 comments
Closed
9 tasks done

[Core] Cherry pick streaming generator PRs #35634

rkooo567 opened this issue May 22, 2023 · 8 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core release-blocker P0 Issue that blocks the release

Comments

@rkooo567
Copy link
Contributor

rkooo567 commented May 22, 2023

What happened + What you expected to happen

We want to support the streaming generator for ray serve by Ray 2.5. We need to cherry-pick all these commits.

Versions / Dependencies

master

Reproduction script

n/a

Issue Severity

None

@rkooo567 rkooo567 added bug Something that is supposed to be working; but isn't release-blocker P0 Issue that blocks the release core Issues that should be addressed in Ray Core labels May 22, 2023
@rkooo567 rkooo567 self-assigned this May 22, 2023
@can-anyscale
Copy link
Collaborator

This is an additional feature instead of a a release-blocker fix. Can this wait until 2.6?

@xieus
Copy link

xieus commented May 23, 2023

@can-anyscale This streaming feature is a top priority in collaboration with Serve team. If it doesn't ship, we may have a delayed delivery of LLM serving feature. We should prioritize this.

@can-anyscale
Copy link
Collaborator

@xieus ack!

@zhe-thoughts
Copy link
Collaborator

cc @waleedkadous @edoakes

Yes, @can-anyscale I added you to an email thread

@edoakes
Copy link
Contributor

edoakes commented May 23, 2023

There will be additional Ray Serve PRs to pick, should all be ready by EOW

@ArturNiederfahrenhorst
Copy link
Contributor

@zhe-thoughts @edoakes @rkooo567
As far as I can tell, all the PRs listed here have been merged.
If no tests fail, is this release-blocker resolved?

@zhe-thoughts
Copy link
Collaborator

I agree it can be resolved.

@rkooo567
Copy link
Contributor Author

Should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core release-blocker P0 Issue that blocks the release
Projects
None yet
Development

No branches or pull requests

6 participants