Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add sample yaml RayCluster with FluentBit sidecar to persist Ray logs #2602

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Docs] Add sample yaml RayCluster with FluentBit sidecar to persist Ray logs #2602

merged 1 commit into from
Dec 4, 2024

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Dec 4, 2024 •
edited
Loading

Why are these changes needed?

Adds an example RayCluster with Fluent-Bit sidecar mode to persist Ray logs. and reference the YAML in this PR.

Using downward API to get kubernetes metadata.

        - name: fluentbit
          image: fluent/fluent-bit:3.2.2
          # Get Kubernetes metadata via downward API
          env:
          - name: POD_LABELS
            valueFrom:
              fieldRef:
                fieldPath: metadata.labels['ray.io/cluster']

image

Related issue number

ray-project/ray#49038

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

kevin85421
kevin85421 reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add the YAML to raycluster_test.go?

kevin85421
kevin85421 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge for now. Please address #2602 (review) in a follow up PR.

@kevin85421 kevin85421 merged commit ebf8a53 into ray-project:master Dec 4, 2024
23 checks passed
@kevin85421 kevin85421 mentioned this pull request Dec 4, 2024
Closed
2 tasks
@win5923 win5923 deleted the fluentBit/sidecar branch December 5, 2024 00:30
@win5923 win5923 changed the title [Docs] add sample RayCluster with FluentBit sidecar to persist Ray logs [Docs] Add sample yaml RayCluster with FluentBit sidecar to persist Ray logs Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@andrewsykim andrewsykim

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@win5923 @andrewsykim @kevin85421