Suggest: Version is not just determined from assembly version information!

[goodyu372]

For example, you can determine the version number from a field ，or read the version number from the configuration file.

Why do I have this need? Because some software exe may not be updated for a long time, but the plug-in DLL will be updated.

Therefore, the current condition for judging whether to update is too simple.

[goodyu372]

-<
The author never replied.

[goodyu372]

[ravibpatel]

Current condition to determine version is sufficient for most devs. So there are no plans to change it.

[CADbloke]

Here is one good reason to have some flexibility - changing the AssemblyVersion breaks bindings for any app calling the assembly so it should be mostly left the hell alone until your update actually breaks the public API. Reference: https://stackoverflow.com/questions/64602/what-are-differences-between-assemblyversion-assemblyfileversion-and-assemblyin/802038#802038

I use AssemblyFileVersion to determine that actual release version and if I use this library I'll fork it and make that change in hte code referred to in #114

[tNRevan]

+1 for this. My app consists of base app, database (local file) and plugins. The base app and also the plugins can be updated this way. But the database cannot be updated, because it is not an assembly. So in order to do that, I need to either create a fake assembly tied to the database or somehow fake the Assembly.

[Weqqen]

+1
My project uses Assemblyinfo (in fact SharedAssemblyinfo.cs - each project has link to this file).
The dlls itself after build has correct version, but autoupdater don't catch that value

I know that in the manual only the project values are supposed to be taken into consideration, so this issue is not bug in fact but rather feature request.

[AlexBrunnerACAG]

+1 Our projects are all having the same approach as mentioned by Weqqen.
We use the AssemblyFileVersion to specify the version in case of a hotfix version where only single assemblies are exchanged. The fact that the AssemblyVersion remains the same lets us do this without getting binding failures.

[ravibpatel]

I am thinking of providing the extra property to assign the installed version. The field value will be used if it is assigned a value and if it isn't then standard logic will be used.

Would it be sufficient for all the scenarios?

[AlexBrunnerACAG]

Hi Ravi This sounds good – thanks a lot for your immediate feedback. Best regards, Alex Freundliche Grüsse Alex Brunner CTO, Head of Software Development, Partner Dipl. Wirtschaftsinformatiker HF Alex.Brunner@all-consulting.ch<mailto:Alex.Brunner@all-consulting.ch> [cid:image001.jpg@01D60E4B.FB96FA00] ALL CONSULTING AG Schuppisstrasse 10 9016 St. Gallen www.all-consulting.ch<http://www.all-consulting.ch/> Zentrale Fax +41 848 733 733 +41 848 733 734 8306 Brüttisellen / Fabrikweg 2 3018 Bern / Morgenstrasse 129 6023 Rothenburg / Stationsstrasse 89 Die Digitalisierung von Geschäftsprozessen hat in der aktuellen Situation oberste Priorität – sie ermöglicht u.a. die Fortführung des Tagesgeschäfts unter Einhaltung der geforderten Personal Distance aus dem Home Office etc. Mit unserer Expertise unterstützen wir auch Sie dabei, sich entsprechend auszurichten – kontaktieren Sie uns<https://all-consulting.ch/geschaeftstellen/standorte-ch-karte/hauptsitz-st-gallen/>

…

________________________________ Dieses E-Mail wurde durch aktuellste Technologien über mehrere Instanzen auf Viren und Malware geprüft. Der Inhalt dieses E-Mails ist vertraulich. Das E-Mail ist nur für den Adressaten bestimmt. Wenn Sie nicht der beabsichtigte Empfänger sind, sollten Sie uns so schnell als möglich benachrichtigen und dieses E-Mail löschen. In diesem Fall ist es Ihnen nicht gestattet, dieses E-Mail und/oder dessen Inhalt Dritten bekannt zu geben, zu kopieren, oder anderweitig zu verwenden. Widerhandlung ist strafbar. Von: Ravi Patel <notifications@github.com> Gesendet: Donnerstag, 9. April 2020 08:23 An: ravibpatel/AutoUpdater.NET <AutoUpdater.NET@noreply.github.com> Cc: Brunner, Alex <Alex.Brunner@all-consulting.ch>; Comment <comment@noreply.github.com> Betreff: Re: [ravibpatel/AutoUpdater.NET] Suggest: Version is not just determined from assembly version information! (#260) I am thinking of providing the extra property to assign the installed version. The field value will be used if it is assigned a value and if it isn't then standard logic will be used. Would it be sufficient for all the scenarios? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#260 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJN2WAY3PBLCOHLUYDSGPLLRLVSULANCNFSM4HHN4MNA>.

[tNRevan]

I am thinking of providing the extra property to assign the installed version. The field value will be used if it is assigned a value and if it isn't then standard logic will be used.

Would it be sufficient for all the scenarios?

I think that would be a good way.

[Weqqen]

Hi,
I am not sure property of what we are talking about exactly - but if this would be a way to tell updater directly what version it is running on - that would be sufficient.
Thanks!

[AlexBrunnerACAG]

Hi,
for my understanding Ravi is talking about an additional property available in the xml file.
The current property version is compared with the value of assemblyVersionAttribute and not with the value of assemblyFileVersionAttribute.

When just having a hotfix we just increment the assemblyFileVersion and the assemblyVersion remains the same. In the following sample the assemblyFileVersion is set to 3.0.1.10009.
When checking for updates this will be correctly recognized as update.
But after the update the check again says that there's an update available becuase 3.0.1.10009 is compared to the assemblyVersion which is set to 3.0.1. This can be seen in the screenshot of the updater dialog.

Having an additional property in the xml like fileVersion would then give the chance to compare the fileVersion attribute with the assemblyFileVersion attribute.
This should then be working properly.

Best regards,
Alex

[ravibpatel]

I was thinking about adding CurrentVersion property to the AutoUpdater class. So you can set it to whatever you want. When there is an update check it will compare the latest version retrieved from the XML file with this CurrentVersion property if it is present. This way anyone can implement their own logic to determine the current version.

[AlexBrunnerACAG]

That's perfect. This way we can implement our behavior easily.

[ravibpatel]

I added the feature in the latest commit. You can try it from here. You should be able to assign the installed version manually as shown below.

AutoUpdater.InstalledVersion = new Version("1.2");
AutoUpdater.Start("Your XML file URL");

Please test it and provide your feedback so I can publish the NuGet package.

[Weqqen]

W dniu 27.07.2020 o 14:19, Ravi Patel pisze:

I added the feature in the latest commit. You can try it from here <https://ci.appveyor.com/api/buildjobs/8dl1v6cvtbh4wlvv/artifacts/AutoUpdater.NET-1.6.1.zip>. You should be able to assign the installed version manually as shown below. AutoUpdater.InstalledVersion = new Version("1.2"); AutoUpdater.Start("Your XML file URL"); Please test it and provide your feedback so I can publish the NuGet package. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHKQ3RMAHTNVOIKY43ELE3R5VWEPANCNFSM4HHN4MNA>.

Hi, I would gladly but I am on the vacation. I wille check it as soon as possible. Still - thanks for the modification! GN

[AlexBrunnerACAG]

Hi,

I integrated the 1.6.1 and did the following test.

I've used the following code to set the AssemblyFileVersion as AutoUpdater.InstalledVersion:

      FileVersionInfo fvi = FileVersionInfo.GetVersionInfo(Application.ExecutablePath);
      AutoUpdater.InstalledVersion = new Version(fvi.FileVersion);

The behavior is as expected.

Thanks for the change.

Best regards,
Alex

[ravibpatel]

Updated the NuGet package to v1.6.1 with this feature.