forked from apache/arrow
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
apacheGH-39484: [Java] Support 256 bit decimals in JdbcToArrowUtils (a…
…pache#39485) ### Rationale for this change This PR allows users of `JdbcToArrowUtils` to convert 256 bit decimals. ### What changes are included in this PR? Add a `Decimal256Consumer` and logic to ### Are these changes tested? No, at this point there are no good tests for JDBC consumers. ### Are there any user-facing changes? Converting 256 bit decimals and ints bigger than 64 bit should now work * Closes: apache#39484 Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
- Loading branch information
Showing
2 changed files
with
141 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
...adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/Decimal256Consumer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,128 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.arrow.adapter.jdbc.consumer; | ||
|
||
import java.math.BigDecimal; | ||
import java.math.RoundingMode; | ||
import java.sql.ResultSet; | ||
import java.sql.SQLException; | ||
|
||
import org.apache.arrow.vector.Decimal256Vector; | ||
|
||
/** | ||
* Consumer which consume decimal type values from {@link ResultSet}. | ||
* Write the data to {@link org.apache.arrow.vector.Decimal256Vector}. | ||
*/ | ||
public abstract class Decimal256Consumer extends BaseConsumer<Decimal256Vector> { | ||
private final RoundingMode bigDecimalRoundingMode; | ||
private final int scale; | ||
|
||
/** | ||
* Constructs a new consumer. | ||
* | ||
* @param vector the underlying vector for the consumer. | ||
* @param index the column id for the consumer. | ||
*/ | ||
public Decimal256Consumer(Decimal256Vector vector, int index) { | ||
this(vector, index, null); | ||
} | ||
|
||
/** | ||
* Constructs a new consumer, with optional coercibility. | ||
* @param vector the underlying vector for the consumer. | ||
* @param index the column index for the consumer. | ||
* @param bigDecimalRoundingMode java.math.RoundingMode to be applied if the BigDecimal scale does not match that | ||
* of the target vector. Set to null to retain strict matching behavior (scale of | ||
* source and target vector must match exactly). | ||
*/ | ||
public Decimal256Consumer(Decimal256Vector vector, int index, RoundingMode bigDecimalRoundingMode) { | ||
super(vector, index); | ||
this.bigDecimalRoundingMode = bigDecimalRoundingMode; | ||
this.scale = vector.getScale(); | ||
} | ||
|
||
/** | ||
* Creates a consumer for {@link Decimal256Vector}. | ||
*/ | ||
public static JdbcConsumer<Decimal256Vector> createConsumer( | ||
Decimal256Vector vector, | ||
int index, | ||
boolean nullable, | ||
RoundingMode bigDecimalRoundingMode | ||
) { | ||
if (nullable) { | ||
return new NullableDecimal256Consumer(vector, index, bigDecimalRoundingMode); | ||
} else { | ||
return new NonNullableDecimal256Consumer(vector, index, bigDecimalRoundingMode); | ||
} | ||
} | ||
|
||
protected void set(BigDecimal value) { | ||
if (bigDecimalRoundingMode != null && value.scale() != scale) { | ||
value = value.setScale(scale, bigDecimalRoundingMode); | ||
} | ||
vector.set(currentIndex, value); | ||
} | ||
|
||
|
||
/** | ||
* Consumer for nullable decimal. | ||
*/ | ||
static class NullableDecimal256Consumer extends Decimal256Consumer { | ||
|
||
/** | ||
* Instantiate a Decimal256Consumer. | ||
*/ | ||
public NullableDecimal256Consumer(Decimal256Vector vector, int index, RoundingMode bigDecimalRoundingMode) { | ||
super(vector, index, bigDecimalRoundingMode); | ||
} | ||
|
||
@Override | ||
public void consume(ResultSet resultSet) throws SQLException { | ||
BigDecimal value = resultSet.getBigDecimal(columnIndexInResultSet); | ||
if (!resultSet.wasNull()) { | ||
// for fixed width vectors, we have allocated enough memory proactively, | ||
// so there is no need to call the setSafe method here. | ||
set(value); | ||
} | ||
currentIndex++; | ||
} | ||
} | ||
|
||
/** | ||
* Consumer for non-nullable decimal. | ||
*/ | ||
static class NonNullableDecimal256Consumer extends Decimal256Consumer { | ||
|
||
/** | ||
* Instantiate a Decimal256Consumer. | ||
*/ | ||
public NonNullableDecimal256Consumer(Decimal256Vector vector, int index, RoundingMode bigDecimalRoundingMode) { | ||
super(vector, index, bigDecimalRoundingMode); | ||
} | ||
|
||
@Override | ||
public void consume(ResultSet resultSet) throws SQLException { | ||
BigDecimal value = resultSet.getBigDecimal(columnIndexInResultSet); | ||
// for fixed width vectors, we have allocated enough memory proactively, | ||
// so there is no need to call the setSafe method here. | ||
set(value); | ||
currentIndex++; | ||
} | ||
} | ||
} |