Optimize "back to list" behavior with back button #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the button so that it replaces the current route when clicking "back to list" after having added (or edited or deleted) a webmark. This considerably improves the behavior when a user saves a webmark from the bookmarklet or the system's native share dialog (e.g. on Android). Currently, if they're going back to the list, and then decide to go back to the original page, they only go back to the add/edit form. With this change, they go back immediately to the original page. Or, when using the system's share function, the entire overlay browser window will be closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the button so that it replaces the current route when clicking "back to list" after having added (or edited or deleted) a webmark.
This considerably improves the behavior when a user saves a webmark from the bookmarklet or the system's native share dialog (e.g. on Android). Currently, if they're going back to the list, and then decide to go back to the original page, they only go back to the add/edit form. With this
change, they go back immediately to the original page. Or, when using the system's share function, the entire overlay browser window will be closed.