-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dangerous buttons to password protected area #235
Comments
Firmware updates and re-pairing are already password protected... if you are not seeing the prompt then it is because browsers cache credentials and only request userid/password if credentials expire or change. Those and reboot are also wrapped with a "are you sure" popup. Reboot is not password protected. This was a conscious decision as reboot is non-destructive, it takes ~30 seconds to reboot and re-connect to the Apple Home network. |
I'm glad to hear it's secure, but it's not obvious that it is. I knew to test in incognito mode, but I wasn't expecting the password prompt to be after the point of no return. I assumed that "are you sure" meant there were no further guardrails. Will you consider showing the password prompt right after the first click for the firmware and unpair buttons to make it more obvious? |
Yes, let me check that, we can change to do the credentials check before the are you sure pop up. Thanks for the suggestion. |
I have made this change in PR #227 so will be included in next release. |
fixed in v1.7.1 |
I'd like to see the Firmware Update, Un-pair HomeKit, and Reboot buttons moved to the password protected page. Those are "admin" level features that could be used to covertly break into the house. (the other buttons are fine because they generate notifications)
The text was updated successfully, but these errors were encountered: