Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(apply): fixes the secret guid functor in the resolver #321

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

pallabpain
Copy link
Contributor

@pallabpain pallabpain commented Jun 10, 2024

Description

While fixing a regression, the guid functor for secret was updated to return a name. This led to a regression in the apply command where secrets created along with other packages weren't being resolved correctly. This commit fixes that.

Testing

Used the following test manifest:

---
apiVersion: apiextensions.rapyuta.io/v1
kind: Secret
metadata:
  name: test-secret
spec:
  type: Docker
  docker:
    registry: quay.io/rapyuta
    username: "quayuser"
    password: "quaypass"
    email: rr@rr.com
---
apiVersion: "apiextensions.rapyuta.io/v1"
kind: Package
metadata:
  name: "nginx"
  version: "1.0.0"
  labels:
    app: nginx
spec:
  runtime: cloud
  cloud:
    replicas: 1
  executables:
    - name: nginx
      type: docker
      docker:
        image: nginx
        pullSecret:
          depends:
            kind: secret
            nameOrGUID: "test-secret"

While fixing a regression, the guid  functor for secret was updated to
return a name. This led to a regression in the apply command where
secrets created along with other packages weren't being resolved
correctly. This commit fixes that.
@pallabpain pallabpain requested review from a team as code owners June 10, 2024 19:37
@pallabpain pallabpain self-assigned this Jun 10, 2024
@pallabpain pallabpain requested a review from ankitrgadiya June 10, 2024 19:38
@pallabpain pallabpain added the 🐛 bug Something isn't working label Jun 10, 2024
Copy link

🤖 Pull Request Artifacts (#9454495918) 🎉

@pallabpain pallabpain merged commit bf103bc into devel Jun 11, 2024
6 checks passed
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/secret-guid-functor branch October 14, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants