Skip to content

Commit

Permalink
fix(v2client): updates limits for list secrets and routes (#270)
Browse files Browse the repository at this point in the history
The existing limits for list secrets and static routes was set to 10
which is quite low. This leads to increased number of calls to the
apiserver. This commit increases the limit to 50, reducing the number of
calls required to fetch all the items.
  • Loading branch information
pallabpain authored Feb 8, 2024
1 parent fd2a881 commit 862fdfc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions riocli/v2client/client.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 Rapyuta Robotics
# Copyright 2024 Rapyuta Robotics
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -342,7 +342,7 @@ def list_static_routes(
while True:
params.update({
"continue": offset,
"limit": 10,
"limit": 50,
})
response = RestClient(url).method(HttpMethod.GET).query_param(
params).headers(headers).execute()
Expand Down Expand Up @@ -463,7 +463,7 @@ def list_secrets(
while True:
params.update({
"continue": offset,
"limit": 10,
"limit": 50,
})
response = RestClient(url).method(HttpMethod.GET).query_param(
params).headers(headers).execute()
Expand Down

0 comments on commit 862fdfc

Please sign in to comment.