Skip to content

Commit

Permalink
fix(jsonschema): corrects the deployment component spec (#264)
Browse files Browse the repository at this point in the history
The depends attribute of the deployment schema is defined under the
componentSpec which violates the additionalProperties=False setting of
the dependencies for each runtime. This commit correct that by
explicitly adding the depends section for each runtime.
  • Loading branch information
pallabpain authored Feb 1, 2024
1 parent 4ee6f43 commit 3f848bf
Showing 1 changed file with 8 additions and 14 deletions.
22 changes: 8 additions & 14 deletions riocli/jsonschema/schemas/deployment-schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,6 @@ definitions:
enum:
- device
- cloud
depends:
type: array
items:
"$ref": "#/definitions/deploymentDepends"
dependencies:
runtime:
oneOf:
Expand All @@ -135,6 +131,10 @@ definitions:
type: string
enum:
- device
depends:
type: array
items:
"$ref": "#/definitions/deploymentDepends"
device:
type: object
properties:
Expand All @@ -151,22 +151,18 @@ definitions:
type: array
items:
"$ref": "#/definitions/envArgsSpec"

volumes:
type: array
items:
"$ref": "#/definitions/deviceVolumeAttachSpec"

rosNetworks:
type: array
items:
"$ref": "#/definitions/deviceNetworkAttachSpec"

rosBagJobs:
type: array
items:
"$ref": "#/definitions/deviceROSBagJobSpec"

features:
type: object
properties:
Expand All @@ -191,7 +187,10 @@ definitions:
type: string
enum:
- cloud

depends:
type: array
items:
"$ref": "#/definitions/deploymentDepends"
features:
type: object
properties:
Expand Down Expand Up @@ -219,27 +218,22 @@ definitions:
type: array
items:
"$ref": "#/definitions/envArgsSpec"

volumes:
type: array
items:
"$ref": "#/definitions/cloudVolumeAttachSpec"

staticRoutes:
type: array
items:
"$ref": "#/definitions/endpointSpec"

rosNetworks:
type: array
items:
"$ref": "#/definitions/cloudNetworkAttachSpec"

managedServices:
type: array
items:
"$ref": "#/definitions/managedServiceSpec"

rosBagJobs:
type: array
items:
Expand Down

0 comments on commit 3f848bf

Please sign in to comment.