Fix errors when filter does not exist #979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes to Core Features:
The application throws an error when supplying an invalid filter key in the URL. The appropriate action would be to ignore the invalid filter key.
Steps to reproduce
http://localhost:8000/dashboard?table[filters][invalid-filter]=test
.Errors it fixes
Rappasoft\LaravelLivewireTables\DataTableComponent::Rappasoft\LaravelLivewireTables\Traits\Helpers\{closure}(): Argument #1 ($filter) must be of type Rappasoft\LaravelLivewireTables\Views\Filter, null given, called in /..../src/Illuminate/Collections/Traits/EnumeratesValues.php on line 780
Error: Call to a member function isEmpty() on null: /..../src/Traits/ComponentUtilities.php:97
I expect that the application does not accept invalid filters (filters not defined in filters()) and doesn't error on such input.
This PR fixes this behavior.