Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customSortButtonAttributes except wire:key #754

Merged
merged 1 commit into from
May 3, 2022
Merged

customSortButtonAttributes except wire:key #754

merged 1 commit into from
May 3, 2022

Conversation

marcheffels
Copy link

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Reproduce: Go to the Demo page and deselect the name or another column. It will looks like

Screenshot 2022-05-03 at 13-03-17 Tailwind 2 Tables

I can't explain exactly why removing wire:key is the solution. I looked for the last changes of the file. At the commit setThSortButtonAttributes was the hardcoded classes replaced with customSortButtonAttributes and this work added wire:key to the button. Maybe this issue comes because the same wire:key is set on tow html tags (th and button).

@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label May 3, 2022
@rappasoft rappasoft mentioned this pull request May 3, 2022
@rappasoft rappasoft merged commit 79995b7 into rappasoft:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants