Patch add attributes to filters #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filter views, maybe allow for future support of attributes on generic filter views
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new $attributes property to filters. This allows for custom attributes to be added to a filter when calling __construct() or make(). Presently, this it to accommodate custom usage of filters() (i.e. rendering on a dashboard search with multiple filters) and doesn't affect any of the built-in filter rendering.
While this has no effect on the current usage of filters, if approved, it would allow us to make a later PR that adds support for rendering attributes on the filter resources. For example, we can merge CSS classes defined with Filter::make() into the rendering of that filter.