Allow dot notation for customer attributes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to propose allowing the use of dot notation for accessing nested attributes via relationships when using custom attributes.
Eg: For a table of posts, instead of adding an accessor attribute to the Post model `getAuthorFullNameAttribute()`, using dot notation, you can simply access the authors full_name attribute directly, through the relationship:
```
Column::make(__('Author'), 'author.full_name')
->customAttribute()
->searchable()
->sortable(),
```
Thanks for this awesome package. Truly is a pleasure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose allowing the use of dot notation for accessing nested attributes via relationships when using custom attributes.
Eg: For a table of posts, instead of adding an accessor attribute to the Post model
getAuthorFullNameAttribute(), using dot notation, you can simply access the authors full_name attribute directly, through the relationship:The
data_get()helper method will be available even outside of Laravel since Livewire already requiresilluminate/support.Thanks for this awesome package. Truly is a pleasure.