new feature: searchable() #233
Conversation
Remove padding from bootstrap container to keep it flush with sides like Tailwind
Removed hard coded bulk text
…laravel-livewire-tables into feature-searchable
…laravel-livewire-tables into feature-searchable # Conflicts: # src/Traits/WithFilters.php
…laravel-livewire-tables into feature-searchable
|
Gonna need to have some actual documentation after all these features we're plowing into this thing. |
| { | ||
| return $this->rowsQuery(); | ||
| // sorting? | ||
| if (method_exists($this, 'applySorting')) { |
There was a problem hiding this comment.
Shouldn't these two methods always exist since they are part of the package and not user defined?
There was a problem hiding this comment.
They are defined in traits, so as long as the traits are applied to the class. I could go either way given this implementation if you have a preference.
In general I assume that traits are meant to be mixed and matched. So, maybe there is a future scenario where someone would need a table component but without specific traits.
E.g. I could see on #200 the possibility of creating a separate component for collections which may call for excluding these traits (or mixing in others).
There was a problem hiding this comment.
True, though in the case of this package even though the traits are functional, they were more meant for organizational purposes. Having them doesn't hurt though.
|
Ok I have some cleanup done locally and everything is working well, I actually can't find a need for the old way with my test table. The only thing I can't get to work is the searchable closure, no matter what I add in there the search just returns nothing altogether. Since you have a better idea of how it works can you just see if it's working correctly, and then maybe put a little blurb in the readme? |
|
Since I merged this into develop, if you end up finding an issue or want to add to the readme I'll just merge a new PR if you don't mind. I'm going to try to dig into why I can't get it to work tomorrow. This was a great PR by the way that's a lot of work and we all appreciate it. |
|
Thanks! I see the issue with callback and submitted a separate PR: However, I missed your note there about updating the readme. |
Follow-up to #210