Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort array url query #1835

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Aug 10, 2024

This PR fixes an issue where the QueryString for Sorts is converted to dot notation, and throws an error on subsequent refreshes

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 6f5bdc6 into rappasoft:development Aug 10, 2024
7 checks passed
This was referenced Aug 10, 2024
lrljoe added a commit that referenced this pull request Aug 10, 2024
## [v3.4.5] - 2024-08-10
### Bug Fixes
- Fix sort queryString bug by @lrljoe in #1835
@Khangdeptrai253
Copy link

so many bug, such as search input and filter don't show

@lrljoe
Copy link
Collaborator Author

lrljoe commented Aug 18, 2024

so many bug, such as search input and filter don't show

I think you've raised an issue for this, which showed the issue was publishing the views and not updating them.

Raise a new issue if you find something broken please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants