Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blade Minimisation & ColumnSelect Cleanup #1806

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jul 31, 2024

This PR:

  1. Cleans up ColumnSelect to utilise the Helper/Configuration methods
  2. Adds a new "selectedVisibleColumns" to pass into the blades, which is used to determine visible Columns more smoothly
  3. Removes blades from being included, rather than simply hiding the content once rendered, improving performance, for example - Filter Pills/Sort Pills, Collapsed Columns Rows
  4. Fixes the Reorder button Save being visible when it should not be
  5. Fix Collapsed Row Attribute Merging to match the uncollapsed row
  6. Sets collapsed items to be left-aligned when expanding the row

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.06%. Comparing base (40485a0) to head (36c133b).
Report is 14 commits behind head on development.

Files Patch % Lines
src/Traits/Helpers/ColumnSelectHelpers.php 88.09% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1806      +/-   ##
=================================================
+ Coverage          87.14%   88.06%   +0.92%     
- Complexity          1495     1529      +34     
=================================================
  Files                139      141       +2     
  Lines               3484     3560      +76     
=================================================
+ Hits                3036     3135      +99     
+ Misses               448      425      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit a12f07c into rappasoft:development Jul 31, 2024
@lrljoe lrljoe mentioned this pull request Aug 1, 2024
9 tasks
lrljoe added a commit that referenced this pull request Aug 4, 2024
## [v3.4.0] - 2024-08-04
### New Features
- Add Helpers for TextFilters by @lrljoe in #1812
- Change method names for TextFilters handler by @lrljoe in #1814
- Capability to set Reorder Column TH Attributes by @lrljoe in #1811
- Bulk Actions - Customise Select All Behaviours by @lrljoe in #1810

### Bug Fixes
- Fix loading spinner for dark tailwind theme by @lrljoe in #1809

### Tweaks
- Blade Minimisation & ColumnSelect Cleanup by @lrljoe in #1806
- Adjust DateColumn with Missing Tests and Coping with DateTime Casts by @lrljoe in #1813

### Docs
- Add reference to Bulk Actions TH styling in main styling by @lrljoe in #1808
- Update docs for setPillsLocale by @lrljoe in #1800
- Add note on label method for setAdditionalSelects by @lrljoe in #1816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant