Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-setDefaultPerPage Method #1671

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Feb 29, 2024

This adds to the pagination methods available.
Presently setPerPage is used for setting the per-page value
Therefore using it in configure() or similar will over-ride anything defined via the querystring or session

To rectify this, setDefaultPerPage is being added, to be used to set a default per-page value, which will only be used if perPage is the default (10) value, otherwise it will respect what is currently set (e.g. via the session/querystring)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (52dac06) to head (0174d79).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1671      +/-   ##
=============================================
+ Coverage      88.12%   88.14%   +0.01%     
- Complexity      1310     1312       +2     
=============================================
  Files            123      123              
  Lines           3100     3105       +5     
=============================================
+ Hits            2732     2737       +5     
  Misses           368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit bc3d2f3 into rappasoft:develop Feb 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Per Page doesn't apply when returning to the table
1 participant