Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change traits to booted #1603

Merged
merged 12 commits into from
Dec 26, 2023
Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 20, 2023

This PR changes the standard events to run on booted() rather than boot(), allowing mount() to take place first.

Additionally adds missing tests for:

  • Using mount() in conjunction with builder()
  • Ensure mount() is called prior to bundler() executing
  • Ensuring that correct Exception is thrown if no columns are configured.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c307360) 88.53% compared to head (ada2bce) 88.56%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1603      +/-   ##
=============================================
+ Coverage      88.53%   88.56%   +0.03%     
  Complexity      1346     1346              
=============================================
  Files            106      106              
  Lines           3167     3167              
=============================================
+ Hits            2804     2805       +1     
+ Misses           363      362       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 4e75b3d into rappasoft:develop Dec 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant