V3 - Filter DTOs #1503
Merged
V3 - Filter DTOs #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1503 +/- ##
=============================================
+ Coverage 88.08% 88.53% +0.45%
- Complexity 1251 1254 +3
=============================================
Files 94 95 +1
Lines 3013 2975 -38
=============================================
- Hits 2654 2634 -20
+ Misses 359 341 -18
|
lrljoe
added a commit
that referenced
this pull request
Nov 2, 2023
* v3-Move ConfigurableAreas to Own Section WithConfigurableAreas (#1510) * Move ConfigurableAreas to Own Trait --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes (#1514) * Splitting ConfigurableAreas into Traits * Splitting TableAttributes into Traits * Splitting CollapsingColumns into Traits * Add HasAllTraits Trait --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * V3 - Filter DTOs (#1503) * Initial Update - Using DTO * Add filterGenericData * Remove requirement for method on render for Filter * Remove Render requirement * GenericHeaderTest * Add filter comparison --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update Search to Default Live (#1517) * Update Search to Default Live * Search Live Default - Test Fixes * V3 add custom filter view (#1518) * Add viewPath for Filters * Update Filter ViewPath * Add available methods for setCustomView * Add Tests * Migrate Column/Filter View properties to IsColumn & IsFilter traits to standardise * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * V3 Rename row-contents blades (#1519) * Rename row-contents to collapsed-columns * Update Change Log --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pre-requisite for several upcoming improvements to filter behaviour.
The key changes within this PR are:
These changes will smooth the approach for future Filter improvements by allowing for:
a) Standardised Behaviour of Filter Render methods
b) Removal of defined properties from blades relating to Filter rendering
c) Exposing a DTO so that it is simpler for third parties to extend existing filters
All Submissions:
New Feature Submissions:
Changes to Core Features: