v3 Toolbar - Splitting of Views/Blades #1454

lrljoe · 2023-10-25T23:24:21Z

THIS IS IN PROGRESS - DO NOT MERGE OR USE.

This PR separates out the toolbar into blades per function, removes the duplication for themes (except one item), and tries to clean up the approach for maintainability.

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

Does your submission pass tests and did you add any new tests needed for your feature?
Did you update all templates (if applicable)?
Did you add the relevant documentation (if applicable)?
Did you test locally to make sure your feature works as intended?

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

lrljoe · 2023-10-26T00:03:31Z

Removing content from old tailwind/bootstrap toolbar blades
Using split toolbars

codecov · 2023-10-26T00:05:14Z

Codecov Report

Merging #1454 (e116b8e) into v3-develop (bdb9b8b) will not change coverage.
Report is 1 commits behind head on v3-develop.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             v3-develop    #1454   +/-   ##
=============================================
  Coverage         88.11%   88.11%           
  Complexity         1222     1222           
=============================================
  Files                85       85           
  Lines              2971     2971           
=============================================
  Hits               2618     2618           
  Misses              353      353

lrljoe · 2023-10-26T00:05:27Z

Needs final testing - ensure that no adverse effects

* v3 - Fix - Correct setFilter behaviour (#1451) * Fix for setFilter * Update return types --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Fixes for missing brackets (#1455) * v3 Toolbar - Splitting of Views/Blades (#1454) * Initial Commit - Full Split of Toolbar * Remove Confirms Code * Fix superfluous endif * Combining Blades - Stage 1 * More Merging * Bulk Actions - Icon Adjustment * Further clean up of toolbar - filter button * Stripping Toolbar Theme Distinctions * Adjust childElementOpen to respect hierachy * To remove files * Merge Column-Select into Single Blade * Clean Up Blades * Fix missing BootStrap Classes from Toolbar Blade (#1466) * Adding x-cloak where it is missing for x-show (#1463) * V3 - QueryString migration into Traits (#1465) * Initial migration of queryString to Traits * Lock $queryStringStatus * Add WithQueryString Trait * Add default queryStringStatus --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update Changelog (#1467) --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* v3 - Fix - Correct setFilter behaviour (#1451) * Fix for setFilter * Update return types --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Fixes for missing brackets (#1455) * v3 Toolbar - Splitting of Views/Blades (#1454) * Initial Commit - Full Split of Toolbar * Remove Confirms Code * Fix superfluous endif * Combining Blades - Stage 1 * More Merging * Bulk Actions - Icon Adjustment * Further clean up of toolbar - filter button * Stripping Toolbar Theme Distinctions * Adjust childElementOpen to respect hierachy * To remove files * Merge Column-Select into Single Blade * Clean Up Blades * Fix missing BootStrap Classes from Toolbar Blade (#1466) * Adding x-cloak where it is missing for x-show (#1463) * V3 - QueryString migration into Traits (#1465) * Initial migration of queryString to Traits * Lock $queryStringStatus * Return empty arrays for Traits * Add WithQueryString Trait * Add Config/Helper Traits to WithQueryString * Add default queryStringStatus --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update Changelog (#1467) * v3 DateRange - Icon Styling, FilterHelper Method (#1490) * DateRange - Icon Styling, FilterHelper Method * Add can_get_datestring test * Add non-array test for DateRangeFilter --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * V3 DateRangeFilter - Remove Icon, Add Placeholder (#1492) * Remove DateRangeFilter Icon * DateRangeFilter - Remove Icon & Add Placeholder * Use FilterHelper method to generate wire:key, add placeholder with docs (#1493) * For all Filters (Except MultiSelect currently), use the FilterHelper method to generate the wire:key rather than doing it in the blade. This centralises for future updates MultiSelectFilter will follow in due course, as it requires some tidying & updates. * Add placeholder config option to: DateRangeFilter, DateFilter, DateTimeFilter, NumberFilter and update docs to reflect the availability of the option * Clean up classes on Filters * Minor tweaks to toolbar/column select styling (#1494) --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* v3 - Fix - Correct setFilter behaviour (#1451) * Fix for setFilter * Update return types --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Fixes for missing brackets (#1455) * v3 Toolbar - Splitting of Views/Blades (#1454) * Initial Commit - Full Split of Toolbar * Remove Confirms Code * Fix superfluous endif * Combining Blades - Stage 1 * More Merging * Bulk Actions - Icon Adjustment * Further clean up of toolbar - filter button * Stripping Toolbar Theme Distinctions * Adjust childElementOpen to respect hierachy * To remove files * Merge Column-Select into Single Blade * Clean Up Blades * Fix missing BootStrap Classes from Toolbar Blade (#1466) * Adding x-cloak where it is missing for x-show (#1463) * V3 - QueryString migration into Traits (#1465) * Initial migration of queryString to Traits * Lock $queryStringStatus * Return empty arrays for Traits * Add WithQueryString Trait * Add Config/Helper Traits to WithQueryString * Add default queryStringStatus --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update Changelog (#1467) * v3 DateRange - Icon Styling, FilterHelper Method (#1490) * DateRange - Icon Styling, FilterHelper Method * Add can_get_datestring test * Add non-array test for DateRangeFilter --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * V3 DateRangeFilter - Remove Icon, Add Placeholder (#1492) * Remove DateRangeFilter Icon * DateRangeFilter - Remove Icon & Add Placeholder * Use FilterHelper method to generate wire:key, add placeholder with docs (#1493) * For all Filters (Except MultiSelect currently), use the FilterHelper method to generate the wire:key rather than doing it in the blade. This centralises for future updates MultiSelectFilter will follow in due course, as it requires some tidying & updates. * Add placeholder config option to: DateRangeFilter, DateFilter, DateTimeFilter, NumberFilter and update docs to reflect the availability of the option * Clean up classes on Filters * Minor tweaks to toolbar/column select styling (#1494) * v3-RestoreBulkActionConfirm (#1500) * Bulk Action Confirm * Adjust changelog --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

V3.1.0 Release * v3 - Fix - Correct setFilter behaviour (#1451) * Fix for setFilter * Update return types --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Fixes for missing brackets (#1455) * v3 Toolbar - Splitting of Views/Blades (#1454) * Initial Commit - Full Split of Toolbar * Remove Confirms Code * Fix superfluous endif * Combining Blades - Stage 1 * More Merging * Bulk Actions - Icon Adjustment * Further clean up of toolbar - filter button * Stripping Toolbar Theme Distinctions * Adjust childElementOpen to respect hierachy * To remove files * Merge Column-Select into Single Blade * Clean Up Blades * Fix missing BootStrap Classes from Toolbar Blade (#1466) * Adding x-cloak where it is missing for x-show (#1463) * V3 - QueryString migration into Traits (#1465) * Initial migration of queryString to Traits * Lock $queryStringStatus * Return empty arrays for Traits * Add WithQueryString Trait * Add Config/Helper Traits to WithQueryString * Add default queryStringStatus --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update Changelog (#1467) * v3 DateRange - Icon Styling, FilterHelper Method (#1490) * DateRange - Icon Styling, FilterHelper Method * Add can_get_datestring test * Add non-array test for DateRangeFilter --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * V3 DateRangeFilter - Remove Icon, Add Placeholder (#1492) * Remove DateRangeFilter Icon * DateRangeFilter - Remove Icon & Add Placeholder * Use FilterHelper method to generate wire:key, add placeholder with docs (#1493) * For all Filters (Except MultiSelect currently), use the FilterHelper method to generate the wire:key rather than doing it in the blade. This centralises for future updates MultiSelectFilter will follow in due course, as it requires some tidying & updates. * Add placeholder config option to: DateRangeFilter, DateFilter, DateTimeFilter, NumberFilter and update docs to reflect the availability of the option * Clean up classes on Filters * Minor tweaks to toolbar/column select styling (#1494) * v3-RestoreBulkActionConfirm (#1500) * Bulk Action Confirm * Adjust changelog * v3.1.0 Release (#1505) --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

lrljoe added 7 commits October 23, 2023 19:25

Initial Commit - Full Split of Toolbar

83f36ac

Remove Confirms Code

4e3f2df

Fix superfluous endif

83ad32f

Combining Blades - Stage 1

7ddebe0

More Merging

3d44e82

Bulk Actions - Icon Adjustment

51cfffd

Further clean up of toolbar - filter button

d7f9039

lrljoe self-assigned this Oct 25, 2023

lrljoe added 4 commits October 26, 2023 00:34

Stripping Toolbar Theme Distinctions

7f44ed8

Adjust childElementOpen to respect hierachy

5e19691

To remove files

9a3d2c3

Merge branch 'v3-develop' into v3-ToolbarSplit

7c42a7b

Merge Column-Select into Single Blade

6ab1c6b

lrljoe mentioned this pull request Oct 26, 2023

Update toolbar.blade.php #1431

Closed

9 tasks

Clean Up Blades

e116b8e

lrljoe merged commit dc2961a into rappasoft:v3-develop Oct 27, 2023

lrljoe mentioned this pull request Oct 27, 2023

V3 - Develop to Master - Toolbar splitting #1461

Merged

9 tasks

lrljoe deleted the v3-ToolbarSplit branch October 31, 2023 05:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3 Toolbar - Splitting of Views/Blades #1454

v3 Toolbar - Splitting of Views/Blades #1454

lrljoe commented Oct 25, 2023 •

edited

Loading

lrljoe commented Oct 26, 2023

codecov bot commented Oct 26, 2023 •

edited

Loading

lrljoe commented Oct 26, 2023

v3 Toolbar - Splitting of Views/Blades #1454

v3 Toolbar - Splitting of Views/Blades #1454

Conversation

lrljoe commented Oct 25, 2023 • edited Loading

All Submissions:

New Feature Submissions:

Changes to Core Features:

lrljoe commented Oct 26, 2023

codecov bot commented Oct 26, 2023 • edited Loading

Codecov Report

lrljoe commented Oct 26, 2023

lrljoe commented Oct 25, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading