Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - Fix - Correct setFilter behaviour (#1451) #1452

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 25, 2023

  • Fix for setFilter -> ensure that it updates both arrays

  • Update return types


All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

* Fix for setFilter

* Update return types

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
@lrljoe lrljoe self-assigned this Oct 25, 2023
@lrljoe lrljoe added the Version 3 Version 3 of Package label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1452 (bdb9b8b) into v3-master (cbbb283) will not change coverage.
Report is 3 commits behind head on v3-master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             v3-master    #1452   +/-   ##
============================================
  Coverage        88.11%   88.11%           
  Complexity        1222     1222           
============================================
  Files               85       85           
  Lines             2971     2971           
============================================
  Hits              2618     2618           
  Misses             353      353           

@lrljoe lrljoe merged commit 6427cb5 into v3-master Oct 25, 2023
@nathan-io
Copy link

Thanks @lrljoe !

I upgraded to beta8, but after doing so, we're getting an exception on the view where we call the table:

[2023-10-26 02:53:02] local.ERROR: Undefined array key "default" {"view":{"view":"/path/to/project/vendor/rappasoft/laravel-livewire-tables/resources/views/components/table/td.blade.php","data":[]},"userId":1,"exception":"[object] (Spatie\\LaravelIgnition\\Exceptions\\ViewException(code: 0): Undefined array key \"default\" at /path/to/project/vendor/rappasoft/laravel-livewire-tables/resources/views/components/table/td.blade.php:14)

If I downgrade back to beta4, everything works again.

@lrljoe
Copy link
Collaborator Author

lrljoe commented Oct 26, 2023

@nathan-io - if you have published the views, remove the published views, and clear your view cache.

If you're able to share what your configure() looks like, then that'll help me diagnose the issue.

@lrljoe
Copy link
Collaborator Author

lrljoe commented Oct 26, 2023

@nathan-io - fixed in v3.0.0-beta.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version 3 Version 3 of Package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants