Fix - Allows Label Columns to be Sortable

[lrljoe]

Presently in testing

This adds the capability for label-only columns to be sortable, by checking first for the Column by Select Name, but if that is null, checks for the column's existence by Slug Name.

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

1. Does your submission pass tests and did you add any new tests needed for your feature?
2. Did you update all templates (if applicable)?
3. Did you add the relevant documentation (if applicable)?
4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

[lrljoe]

Needs some minor further testing before merging.

[lrljoe]

As far as I can tell, this is now ready @rappasoft - although I'd appreciate you giving it a quick poke before I merge!

This enables a "label" column to be Sortable (via the callback), presently this does not work.

            Column::make('Name Label')
            ->sortable(function (Builder $query, string $direction) {
                return $query->orderBy('name', $direction); 
            })
            ->label(fn($row, Column $column) => $row->name),

[lrljoe]

No change here, just whitespacing

[lrljoe]

No change here, just whitespacing

[lrljoe]

Introduction of "isColumnBySlug" which is used to determine if the Column is an actual column based on the Slug, if it can't be found based on field.

[lrljoe]

This makes an attempt to find the Column based on the SelectName first, but then swaps over to Slug if it can't find the Column.
This allows the Column to be sortable if it has a sortCallback

[lrljoe]

This makes an attempt to find the Column based on the Slug

[lrljoe]

This fails over to finding the Column by Slug if it can't by SelectName

[lrljoe]

This defaults to getColumnSelectName if it is associated with a field. But fails over to finding the Column based on Slug if not.

[rhnkyr]

Any date to release this one? It is really required. Thanks!

[lrljoe]

I'm just waiting on @rappasoft to give it a quick skim, but it'll be in the next release, most likely next weekend.

[rappasoft]

Looks good to me!

[lrljoe]

Thanks @rappasoft Will merge into develop later today.

[lrljoe]

Now in develop - feel free to test if you are using the develop branch @rhnkyr