Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing two minor typos #1171

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Fixing two minor typos #1171

merged 3 commits into from
Apr 25, 2023

Conversation

ChrisThompsonTLDR
Copy link
Contributor

@ChrisThompsonTLDR ChrisThompsonTLDR commented Apr 20, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Collaborator

@lrljoe lrljoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are to documentation and make sense

@lrljoe lrljoe changed the base branch from master to develop April 21, 2023 05:26
@lrljoe
Copy link
Collaborator

lrljoe commented Apr 21, 2023

Changing the PR target to the develop branch (I really need to add some docs around that!), will merge over weekend, when I'm hoping to the final fixes for the next version ready.

Thanks for the contribution!!!

@lrljoe lrljoe merged commit 1a9eed5 into rappasoft:develop Apr 25, 2023
@lrljoe lrljoe added documentation Improvements or additions to documentation Version 2 Version 2 of Package labels May 12, 2023
@rappasoft rappasoft mentioned this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Version 2 Version 2 of Package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants