-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters - New Functionality - Custom filter labels #1110
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Amended to removing formatting adjustments Adding ID to Label Update toolbar.blade.php Adding new line at EOF * Update toolbar.blade.php Adding ID to Wrapper * Amended to removing formatting adjustments Adding ID to Label Adding ID to Wrapper Adding new line at EOF Update toolbar.blade.php Adding ID to Wrapper * Update toolbar.blade.php Adds IDs to Filter Labels Adds IDs to Filter Wrappers Restores removed EOF newline * Restoring New Line at EOF
* Adding childElementOpen attr for all toolbar items. * Adjusting Toolbar to remove errant formatting * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Initial Commit * Add variable to Filter.php
* Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense
* Adding Custom Slug option (#21) Adding new methods & test Adding documentation * Filter label (#22) * Amended to removing formatting adjustments Adding ID to Label Update toolbar.blade.php Adding new line at EOF * Update toolbar.blade.php Adding ID to Wrapper * Amended to removing formatting adjustments Adding ID to Label Adding ID to Wrapper Adding new line at EOF Update toolbar.blade.php Adding ID to Wrapper * Update toolbar.blade.php Adds IDs to Filter Labels Adds IDs to Filter Wrappers Restores removed EOF newline * Restoring New Line at EOF * Adding Filter Custom Pills blade option (#23) * Adding Filter Custom Pills blade option * Removing formatting changes * Get applied filters only non empty (#24) * Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense * Child open attribute (#25) * Adding childElementOpen attr for all toolbar items. * Adjusting Toolbar to remove errant formatting * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Adding getAdditionalSelectRaws (#26) Using selectRaw rather than directly using DB Referencing DB directly rather than a use Fix styling Fixing test Restoring workflows Removing automated on-push Setting up configuration elements, documentation Adding parameterised capability * Update composer.json * Update run-tests.yml * Fix doc types (#27) * Update toolbar.blade.php * Update Filter.php * Update FilterHelpers.php * Fix styling * Update FilterConfiguration.php * Fix styling * Initial DocType Fixes * Fix styling * PHPDoc FIxes * Toolbar Blade Fixes for Pagination * Fix styling * Removing non-nullable return * Fixing DocType issues * Reverting minor tweaks due to PHPUnit failures * Removing PHPStan * Additional PHPDoc Fixes * Fixes for PHPDocTypes * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update composer.json * Custom pill views (#29) * Adding Filter Custom Pills blade option * Removing formatting changes * Initial Commit * Fix styling * Fix for errant line end * Fix styling * Minor Tweaks * Remove ParaTest for this branch * Restore Run-tests for this branch * Remove CustomFilterPil * Reverting Numerous Changes to Doctypes - Branches * Fix Mistaken Branch merge * More remediation to remove branch merges * Fix styling * More removals of branch merge * Adding SlideDownRow and SlideDownColspan Tests * Fix styling * Restoring original workflow * Restoring CS FIxer --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
…/laravel-livewire-tables into customFilterLabels
Closed
8 tasks
8 tasks
See #1111 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for moving the Filter Labels into the Filter Blades, and allowing for the customising of filter labels on a per-filter instance.
This makes several tweaks:
This allows for greater customisation of the labels, and easier styling of the labels for those who wish to customise.
All Submissions:
New Feature Submissions:
Changes to Core Features: