Filters - New Functionality - Set Filter - Custom Pill Blade #1107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial PR just to test appetite from @rappasoft and others (before I start writing tests/docs)
The intention is to provide the ability for Custom Pills Blades for Filters, for a couple of reasons:
To enhance the capability (particularly with Multi-Select or future Filters) to interact with the data more cleanly (removing individual items for example), rather than having to clear a filter completely.
To allow for customisation of look/feel of Pills on a per-filter basis, without the need to publish the main views, removing some of the issues that crop up due to older published views.
This adds the following new methods:
#Added to Views\Traits\FilterHelpers
##hasCustomPillBlade
Determines whether the filter has a custom blade for the pills
##getCustomPillBlade
Retrieves the path for any custom pill blade
#Added To Views\Traits\FilterConfiguration
#Added parameter to Views\Filter
#filter-pills.blade updated to check (after the checks for applied/null/hidden pills)
Initial tests are showing that this works quite smoothly, and doesn't appear to impact performance, although I've not yet scaled it up properly.
All Submissions:
New Feature Submissions:
Changes to Core Features: