Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow (run-tests) - Use of ParaTest, Composer Caching, Fix Stability Matrix Clash #1105

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Mar 17, 2023

Three files modified:

  1. Fix for ColumnsSelectedTest.php class being named ColumnSelectedTest instead of ColumnsSelectedTest

  2. New Composer require-dev for ParaTest rather than straight PHPUnit, which allows for parallel running of PHPUnit tests up to the maximum threads that the CPU is capable of.

  3. Workflow actions major changes:
    a) Introduces use of ParaTest rather than PHPUnit to allow for parallel processing of tests
    b) Re-introduces Laravel 8 to the matrix
    c) Introduces use of Composer Caching to avoid repeated downloads of requirements when running actions. This is a cache per-matrix instance, which expires when the hash of the composer.lock changes.
    d) Removes the clash between the matrix line for stability, and what was enforced prefer-dist.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

rappasoft and others added 5 commits February 16, 2023 13:32
Update run-tests.yml

Fixing typo in class name

Update composer.json

Update run-tests.yml
@lrljoe lrljoe changed the title Workflow modifications Workflow (run-tests) - Use of ParaTest, Composer Caching, Fix Stability Matrix Clash Mar 20, 2023
@lrljoe
Copy link
Collaborator Author

lrljoe commented Mar 20, 2023

@rappasoft - it'd be good if you can check this one out, as it does make running the tests around 400% faster. Very straight forward.
Perhaps use this version on push and the other on pull-request, until you're comfortable?

@rappasoft rappasoft changed the base branch from master to develop March 20, 2023 20:03
@rappasoft rappasoft merged commit 4258a90 into rappasoft:develop Mar 20, 2023
@rappasoft
Copy link
Owner

Everything seems to pass 👍

@lrljoe
Copy link
Collaborator Author

lrljoe commented Mar 20, 2023

Awesome, if you then run the workflow again by doing a push without impacting your composer.json/lock then you should see the steps in the workflow not do a proper "download" it should just say "locking" instead when doing composer update, and ParaTest should work more quickly locally too.

@rappasoft rappasoft mentioned this pull request Apr 8, 2023
@lrljoe lrljoe deleted the WorkflowModifications branch July 15, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants