Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core - New Functionality - Add Custom Column Slug option #1088

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Mar 5, 2023

This adds a new method for the Column: setCustomSlug, this is used when non-latin characters are used for the title of the Column, as otherwise an empty string is returned.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe mentioned this pull request Mar 5, 2023
Adding new methods & test

Adding documentation
@lrljoe lrljoe force-pushed the CustomColumnSlug branch from 7d5af0d to d7fa7a2 Compare March 5, 2023 07:04
@lrljoe
Copy link
Collaborator Author

lrljoe commented Mar 5, 2023

See #1078 for the issue

@lrljoe lrljoe changed the title Adding Custom Slug option Adding Custom Column Slug option Mar 5, 2023
@lrljoe
Copy link
Collaborator Author

lrljoe commented Mar 9, 2023

Seen a few discussion/issues on this issue, which this PR will fix.

@lrljoe lrljoe changed the title Adding Custom Column Slug option Core - New Functionality - Add Custom Column Slug option Mar 20, 2023
@rappasoft rappasoft changed the base branch from master to develop March 20, 2023 20:15
@rappasoft rappasoft merged commit c3a8399 into rappasoft:develop Mar 20, 2023
@lrljoe lrljoe added the Awaiting Next Release Currently merged into development awaiting a release to master label Mar 30, 2023
@rappasoft rappasoft mentioned this pull request Apr 8, 2023
@lrljoe lrljoe deleted the CustomColumnSlug branch July 15, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants