Filters - FIX - Restrict AppliedFilters to only return non-empty #1080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. To avoid this, I've added an additional check for "isEmpty" in the getAppliedFiltersWithValues.
I am somewhat in two minds on this, but figured that using the filter Defaults for anything other than setting up the array keys (i.e. array with keys, but no values) shouldn't really be done, especially as you can apply filter values at component boot with:
Tested against the Demo instance.
All Submissions:
New Feature Submissions:
Changes to Core Features: