Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional AlpineJS Variable for Toolbar Blade - childElementOpen #1076

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Feb 27, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

This adds an additional boolean variable to each dropdown in the Toolbar. As the mouseaway event fires when generated child elements are utilised and clicked on (e.g. Flatpickr, Select2, Dynamic Dropdown), the menu closes, giving a poor user experience.

The variable can be set manually to true (defaults to false), which prevents the menu from closing.

This is only really for developers who are extending the toolbar elements.

No new tests are required, as the default keeps functionality the same as current, and will only be used in additional filters/tools, which should include the relevant tests when utilising the variable.

@lrljoe lrljoe changed the title Child open attribute Additional AlpineJS Variable for Toolbar Blade - childElementOpen Feb 27, 2023
@rappasoft rappasoft changed the base branch from master to develop March 20, 2023 20:14
@rappasoft
Copy link
Owner

Some docs on how to use this might be good too.

@rappasoft rappasoft merged commit 2b44722 into rappasoft:develop Mar 20, 2023
@lrljoe
Copy link
Collaborator Author

lrljoe commented Mar 20, 2023

Yep, I'm planning to add a set of docs on alpine in general, perhaps as a new help section?

Mostly as I've explained a few core concepts like entangling and using the values in columns to people which seem to have been well received and add value.

Just want to avoid cluttering up the core docs which show how straight forward the basics are with complexities that may turn people away.

Happy to take your steer.

@rappasoft
Copy link
Owner

I'm fine with an Alpine help section or maybe an "Extending" section for those custom filter types or whatnot I haven't had the time to look at yet.

@lrljoe
Copy link
Collaborator Author

lrljoe commented Mar 20, 2023

Yeah no worries, I'll make a start on that this eve, as I know at least one other person has produced some custom filters.

I was thinking about giving both repos as examples.

Plus explaining how to go about it yourself

@lrljoe lrljoe added the Awaiting Next Release Currently merged into development awaiting a release to master label Mar 30, 2023
@rappasoft rappasoft mentioned this pull request Apr 8, 2023
@lrljoe lrljoe deleted the ChildOpenAttribute branch July 15, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants