Fix MongoDB throwing error when perPage is string #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, we're using MongoDB in our Laravel project and it seems to require strictly integer type when passing the limit for pagination. Whenever you attempt to change Per Page in frontend it will replace `$perPage` to a string type and when `render` function calls `paginate` it will throw error. This pull request fixes it, but not sure if it is the right place where to type cast.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we're using MongoDB in our Laravel project and it seems to require strictly integer type when passing the limit for pagination.
Whenever you attempt to change Per Page in frontend it will replace
$perPageto a string type and whenrenderfunction callspaginateit will throw error.This pull request fixes it, but not sure if it is the right place where to type cast.