Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column select hidden on tablet or mobile #1031

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 28, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Per updated documentation, adds two new functions to set when the Column Select Dropdown is hidden (Tablet or Mobile), defaults to always visible.

setColumnSelectHiddenOnTablet

Hide column select menu when on tablet or mobile

public function configure(): void
{
    $this->setColumnSelectHiddenOnTablet();
}

setColumnSelectHiddenOnMobile

Hide column select menu when on mobile.

public function configure(): void
{
    $this->setColumnSelectHiddenOnMobile();
}

@rappasoft rappasoft changed the base branch from master to develop February 16, 2023 16:17
@rappasoft rappasoft merged commit 0f3a01b into rappasoft:develop Feb 16, 2023
@rappasoft rappasoft mentioned this pull request Feb 16, 2023
@lrljoe lrljoe deleted the ColumnSelectHiddenOnTabletOrMobile branch July 15, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants