disallow fallback to Make, add devcontainers CI #363
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
Why is falling back problematic? |
Builds with GNU Make tend to be much slower... sometimes prohibitively so. We found that accidentally not providing Ninja in the build environment led to cuGraph wheel builds sometimes timing out after 6 hours, even with an OK Since |
| "features": { | ||
| "ghcr.io/rapidsai/devcontainers/features/cuda:25.4": { | ||
| "version": "11.8", | ||
| "installcuBLAS": true, |
There was a problem hiding this comment.
Do we need these math libraries for UCXX? I don't think we do.
cuDF doesn't have them: https://github.com/rapidsai/cudf/blob/branch-25.04/.devcontainer/cuda11.8-pip/devcontainer.json
Same for CUDA 12.8 pip devcontainers.
There was a problem hiding this comment.
You're totally right, those are unnecessary here. Removed in 7980f3c
ci/release/update-version.sh
Outdated
| # .devcontainer files | ||
| find .devcontainer/ -type f -name devcontainer.json -print0 | while IFS= read -r -d '' filename; do | ||
| sed_runner "s@rapidsai/devcontainers:[0-9.]*@rapidsai/devcontainers:${NEXT_RAPIDS_SHORT_TAG}@g" "${filename}" | ||
| sed_runner "s@rapidsai/devcontainers/features/rapids-build-utils:[0-9.]*@rapidsai/devcontainers/features/rapids-build-utils:${NEXT_RAPIDS_SHORT_TAG_PEP4400}@" "${filename}" |
There was a problem hiding this comment.
| sed_runner "s@rapidsai/devcontainers/features/rapids-build-utils:[0-9.]*@rapidsai/devcontainers/features/rapids-build-utils:${NEXT_RAPIDS_SHORT_TAG_PEP4400}@" "${filename}" | |
| sed_runner "s@rapidsai/devcontainers/features/rapids-build-utils:[0-9.]*@rapidsai/devcontainers/features/rapids-build-utils:${NEXT_RAPIDS_SHORT_TAG_PEP440}@" "${filename}" |
There was a problem hiding this comment.
blegh, this mistake shows that the way I tested in #363 (comment) wasn't great. There I was checking for "nothing was missed", should have also manually scanned the diff for "all the updates look right".
Fixed in 3c774c2
Sorry for making you catch these things in review, I know it's annoying :/
There was a problem hiding this comment.
No worries! Thanks for your work on this PR. :)
|
/merge |
Contributes to rapidsai/build-planning#146
Closes #262
Proposes:
[tool.scikit-build].ninja.make-fallback = false, soscikit-build-corewill not silently fallback to using GNU Make ifninjais not availabledevcontainersCI jobs hereNotes for reviewers
Why add
devcontainersCI jobs in this PR?The
devcontainersare useful for interactive development on this project (including for outside contributors).ucxxbuilding successfully in them is also important for other all-of-RAPIDS builds, like those from https://github.com/rapidsai/devcontainers and other builds based on that repo. Having CI jobs run in PRs (as most of RAPIDs does) allows us to catch issues right here inucxxwhen they happen, instead of only finding out whenucxxxis built as part of a larger devcontainers-based build.How did you set up the
.devcontainersfolder?Copied https://github.com/rapidsai/cugraph/tree/branch-25.04/.devcontainer and changed all the
cugraphreferences toucxx.