Skip to content

Commit

Permalink
refactor CUDA versions in dependencies.yaml (#159)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#7.

Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

### Benefits of this change

* prevents accidental inclusion of multiple `cuda-version` version in environments
* reduces update effort (via enabling more use of globs like `"12.*"`)
* improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - https://github.com/jakirkham

URL: #159
  • Loading branch information
jameslamb authored Jan 11, 2024
1 parent c2f25c8 commit 239b588
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ files:
- build_cpp
- build_python
- checks
- cudatoolkit
- cuda
- cuda_version
- dev
- py_version
- run_python
Expand All @@ -18,12 +19,12 @@ files:
test_cpp:
output: none
includes:
- cudatoolkit
- cuda_version
- test_cpp
test_python:
output: none
includes:
- cudatoolkit
- cuda_version
- py_version
- test_python
checks:
Expand Down Expand Up @@ -92,7 +93,7 @@ dependencies:
- output_types: [conda, requirements]
packages:
- pre-commit
cudatoolkit:
cuda_version:
specific:
- output_types: conda
matrices:
Expand All @@ -116,6 +117,8 @@ dependencies:
cuda: "12.0"
packages:
- cuda-version=12.0
cuda:
specific:
- output_types: conda
matrices:
- matrix:
Expand Down

0 comments on commit 239b588

Please sign in to comment.