Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify-codeowners hook #762

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Add verify-codeowners hook #762

merged 2 commits into from
Feb 3, 2025

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

Issue: rapidsai/pre-commit-hooks#61

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner January 31, 2025 17:33
@KyleFromNVIDIA KyleFromNVIDIA requested review from msarahan and removed request for a team January 31, 2025 17:33
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 31, 2025
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner February 3, 2025 14:56
@KyleFromNVIDIA KyleFromNVIDIA changed the base branch from branch-25.02 to branch-25.04 February 3, 2025 14:56
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 424fcef into rapidsai:branch-25.04 Feb 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleFromNVIDIA @bdice