Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of rapids-env-update #524

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Remove usages of rapids-env-update #524

merged 1 commit into from
Jan 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Reference: https://github.com/rapidsai/ops/issues/2766

Replace rapids-env-update with rapids-configure-conda-channels, rapids-configure-sccache, and rapids-date-string.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner January 16, 2024 19:11
@KyleFromNVIDIA
Remove usages of rapids-env-update
e744a21 
Reference: rapidsai/ops#2766

Replace rapids-env-update with rapids-configure-conda-channels,
rapids-configure-sccache, and rapids-date-string.
@KyleFromNVIDIA KyleFromNVIDIA force-pushed the remove-rapids-env-update branch from 6e9ef76 to e744a21 Compare January 16, 2024 19:14
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jan 16, 2024
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality and removed feature request New feature or request labels Jan 16, 2024
@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 4a97230 into rapidsai:branch-24.02 Jan 16, 2024
16 checks passed
PointKernel pushed a commit to PointKernel/rapids-cmake that referenced this pull request Jan 23, 2024
@KyleFromNVIDIA @PointKernel
Remove usages of rapids-env-update (rapidsai#524)
5b8fa5f 
Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleFromNVIDIA @ajschmidt8 @robertmaynard