Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply install rules for CCCL if we actually downloaded #507

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 16, 2023

Description

This fixes rapids_cpm_cccl to only call the logic for install rules if CCCL was downloaded.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner December 16, 2023 02:30
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Dec 18, 2023
@bdice
Copy link
Contributor Author

bdice commented Dec 18, 2023

/merge

@rapids-bot rapids-bot bot merged commit 252150a into rapidsai:branch-24.02 Dec 18, 2023
14 checks passed
@bdice bdice changed the title Only apply install rules if we actually downloaded Only apply install rules for CCCL if we actually downloaded Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants