Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple entry overrides now sets FetchContent for all entries #494

Merged
merged 5 commits into from
Dec 18, 2023
Merged

multiple entry overrides now sets FetchContent for all entries #494

merged 5 commits into from
Dec 18, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

FetchContent was previously only called for the last entry.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard
Package overrides with multiple entries now sets FetchContent for eac…
16d9619 
…h one

FetchContent was previously only called for the last entry.
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Dec 1, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner December 1, 2023 18:00
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7d2b702 into rapidsai:branch-24.02 Dec 18, 2023
14 checks passed
@robertmaynard robertmaynard deleted the bug/properly-handle-overrides-with-multiple-packages branch December 18, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice