-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix google benchmark name and update version #425
Conversation
Testing downstream: rapidsai/cudf#13528 |
Testing cuml: rapidsai/cuml#5463 |
cuDF passed using the conda package: rapidsai/cudf#13528 This should be good to merge if we can fix the failing test Details
|
/merge |
This must have been merged without testing RMM benchmarks. Nightly build is failing for rmm replay.cpp. Jumping from 1.5.3 to 1.8.0 is a huge jump -- previously public member variables were hidden behind accessors. This should have been tested with all libraries... |
…1293) rapidsai/rapids-cmake#425 updated the google benchmark version to a version that is more than 2 years newer, and the API changed. This PR just changes to use an accessor rather than a public (now private) data member to fix the compilation errors. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Rong Ou (https://github.com/rongou) - Bradley Dice (https://github.com/bdice) URL: #1293
Description
The google benchmark package name was incorrect, making it impossible to find benchmark if it was previously installed. However, the currently pinned version of benchmark has a broken CMake config on conda-forge (it claims it is version 0.0.0) so it cannot be found even with the name fix. This is as good a time as any to go ahead and update to the latest version.
Resolves #424
Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)