Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-format #398

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 13, 2023

This PR updates the clang-format version used by pre-commit.

@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 13, 2023
@bdice bdice marked this pull request as ready for review April 14, 2023 23:25
@bdice
Copy link
Contributor Author

bdice commented Apr 14, 2023

@robertmaynard No reviewers were assigned. Would you like to approve? The version update has no material effect on this repo, but I didn't want to merge without someone else being aware.

@robertmaynard
Copy link
Contributor

@bdice approved

@bdice
Copy link
Contributor Author

bdice commented Apr 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 16970c9 into rapidsai:branch-23.06 Apr 15, 2023
@harrism
Copy link
Member

harrism commented Apr 18, 2023

If a repo (e.g. cuspatial) uses a different clang-format version for its C++ source (e.g. 15.0.7), will there be conflicts with this?

See rapidsai/cuspatial#1072

@bdice
Copy link
Contributor Author

bdice commented Apr 18, 2023

If a repo (e.g. cuspatial) uses a different clang-format version for its C++ source (e.g. 15.0.7), will there be conflicts with this?

See rapidsai/cuspatial#1072

There should not be any conflicts. This configuration only applies to the C++ contents of the rapids-cmake repository. That’s mostly test files. (We only recently added standalone C++ files in this repo.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants