Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce clang-format to rapids-cmake to format C++ code examples #378

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

In preparation of more C++ code being added to rapids-cmake introduce a .clang-format file to the project to keep everything with a consistent style and formatting.

Checklist

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Feb 23, 2023
@robertmaynard robertmaynard requested a review from bdice February 23, 2023 16:36
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you choose the settings? Are they copied from another project?

I was going to recommend adding a pre-commit hook, but it looks like we've already got one. Have we been running it without a format file?

@robertmaynard
Copy link
Contributor Author

I copied the format file from cudf.

Yeah we have been running format without any file so it was using the defaults. But I don't think we ever ran it over the existing c++ files

@bdice
Copy link
Contributor

bdice commented Feb 23, 2023

Thanks! This simplifies #328.

@bdice
Copy link
Contributor

bdice commented Feb 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit 08a851f into rapidsai:branch-23.04 Feb 23, 2023
@robertmaynard robertmaynard deleted the add_clang_format branch February 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants