Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_cuda_init_architectures now supports CUDAARCHS env variable #322

Merged
merged 5 commits into from
Dec 6, 2022
Merged

rapids_cuda_init_architectures now supports CUDAARCHS env variable #322

merged 5 commits into from
Dec 6, 2022

Conversation

robertmaynard
Copy link
Contributor

Description

rapids_cuda_init_architectures now will handle magic values in ENV{CUDAARCHS} allowing users to specify values like NATIVE or ALL via that method.

Fixes #313

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Dec 2, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner December 2, 2022 14:26
bdice
bdice approved these changes Dec 2, 2022
View reviewed changes
testing/cuda/init_arch-native-via-env.cmake Outdated Show resolved Hide resolved
testing/cuda/init_arch-all-via-env.cmake Outdated Show resolved Hide resolved
robertmaynard and others added 2 commits December 6, 2022 11:18
@robertmaynard @bdice
Correct copyright
42b13eb 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@robertmaynard @bdice
Correct copyright
6be249f 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit de91a78 into rapidsai:branch-23.02 Dec 6, 2022
@robertmaynard robertmaynard deleted the bug/handle_cudaarchs_having_magic_values branch December 6, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
rapids-cmake
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] rapids_cuda_init_architectures should check env{CUDAARCHS} for magic values
2 participants
@robertmaynard @bdice