-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cloning Google benchmark #293
Conversation
I should add that cuML and cuGraph's current versions of this function specify the lib dir for gbench, but I don't think we need or want that. Please correct me if I'm wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just a couple of small changes needed
We will want to specify the install directory if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments aside from what @robertmaynard mentioned. Nice, thanks for doing this!
I'm now setting the |
@robertmaynard are you happy with the current state of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@gpucibot merge |
Description
Many RAPIDS libraries use Google benchmark to manage C++ benchmarks. This PR centralizes the dependency and the version management.
Resolves #288.
Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)