Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libcudacxx to 1.8 #253

Merged
merged 5 commits into from
Aug 30, 2022
Merged

Update libcudacxx to 1.8 #253

merged 5 commits into from
Aug 30, 2022

Conversation

robertmaynard
Copy link
Contributor

Fixes #251

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change DO NOT MERGE Hold off on merging; see PR for details labels Aug 25, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner August 25, 2022 14:52
@robertmaynard robertmaynard mentioned this pull request Aug 25, 2022
Closed
3 tasks
@robertmaynard
Copy link
Contributor Author

Verifying via rapidsai/cudf#11596

bdice
bdice approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI passed on rapidsai/cudf#11596. I have a few minor suggestions.

robertmaynard and others added 2 commits August 26, 2022 08:20
@robertmaynard @bdice
Update rapids-cmake/cpm/libcudacxx.cmake
34955e3 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@robertmaynard @bdice
Update rapids-cmake/cpm/libcudacxx.cmake
af93190 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team and removed DO NOT MERGE Hold off on merging; see PR for details labels Aug 26, 2022
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 115270f into rapidsai:branch-22.10 Aug 30, 2022
@robertmaynard robertmaynard deleted the fea/move_to_libcudacxx_1.8 branch August 30, 2022 13:40
@pdmack pdmack mentioned this pull request Sep 23, 2022
Merged
ghost pushed a commit to nv-morpheus/Morpheus that referenced this pull request Sep 23, 2022
@pdmack
Use libcudacxx from NVIDIA repo (#372)
d2e1114 
Remove @ryanolson private fork of libcudacxx now that (we think) the required memory manager is in the upstream.

Rapids latest is 1.8.0
rapidsai/rapids-cmake#253

Authors:
  - Pete MacKinnon (https://github.com/pdmack)

Approvers:
  - Christopher Harris (https://github.com/cwharris)

URL: #372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Upgrade libcudacxx to 1.8.0
2 participants
@robertmaynard @bdice