[BUG] Thrust (and cub) cmake files aren't installed in a rapids specific location #367
Assignees
Labels
Comments
robertmaynard
added a commit
to robertmaynard/rapids-cmake
that referenced
this issue
Mar 15, 2023
Fixes rapidsai#367 This way rapids-cmake versions of these projects don't clash with the upstream versions.
robertmaynard
added a commit
to robertmaynard/rapids-cmake
that referenced
this issue
Mar 15, 2023
Fixes rapidsai#367 This way rapids-cmake versions of these projects don't clash with the upstream versions.
robertmaynard
added a commit
to robertmaynard/rapids-cmake
that referenced
this issue
Mar 15, 2023
Fixes rapidsai#367 This way rapids-cmake versions of these projects don't clash with the upstream versions.
robertmaynard
added a commit
to robertmaynard/rapids-cmake
that referenced
this issue
Mar 22, 2023
Fixes rapidsai#367 This way rapids-cmake versions of these projects don't clash with the upstream versions.
robertmaynard
added a commit
to robertmaynard/rapids-cmake
that referenced
this issue
Mar 27, 2023
Fixes rapidsai#367 This way rapids-cmake versions of these projects don't clash with the upstream versions.
4 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
May 12, 2023
…ith upstream (#393) This way rapids-cmake versions of these projects don't clash with the upstream versions. Fixes #367 Authors: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently we install Thrust (and cub) headers into a RAPIDS specific location in
include/rapids: https://github.com/rapidsai/rapids-cmake/blob/branch-23.04/rapids-cmake/cpm/thrust.cmake#L64We don't do the same for the cmake files, so we're effectively hijacking
find_package(Thrust)calls to point towards our RAPIDS installation when we probably shouldn't be.Steps/Code to reproduce bug
Run a build + install of librmm, where the cmake files for Thrust (and cub) get put into
lib/cmake/thrust(andlib/cmake/cub).Expected behavior
I assume we should put the cmake files in a
rapidssubdirectory of sorts and then handle adding that subdirectory to the cmake module / prefix path as part of the rapids-cmake initialization or something of the sort?The text was updated successfully, but these errors were encountered: