Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand CMAKE_CUDA_ARCHITECTURE to support RAPIDS ( equal to ALL )( #314

Closed
Tracked by #318
robertmaynard opened this issue Dec 1, 2022 · 0 comments · Fixed by #327
Closed
Tracked by #318

Expand CMAKE_CUDA_ARCHITECTURE to support RAPIDS ( equal to ALL )( #314

robertmaynard opened this issue Dec 1, 2022 · 0 comments · Fixed by #327
Assignees
@robertmaynard
Labels
feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

Is your feature request related to a problem? Please describe.
CMake 3.23+ now offers support for all and all-major as special keywords to CMAKE_CUDA_ARCHITECTURES. This means that rapids-cmake overload on ALL now creates confusion and breaks expectations ( trxcllnt/rapids-compose#84 https://gitlab.kitware.com/cmake/cmake/-/issues/23739, #104 )

Describe the solution you'd like
What we should do is offer a new magic value named RAPIDS which will be the defacto way to build for the subset of CUDA architectures that RAPIDS projects need to support ( a subset of all-major ).
@robertmaynard robertmaynard added the feature request New feature or request label Dec 1, 2022
This was referenced Dec 1, 2022
Closed
Open
@robertmaynard robertmaynard changed the title [FEA] Expand CMAKE_CUDA_ARCHITECTURE to support RAPIDS ( equal to ALL )( Expand CMAKE_CUDA_ARCHITECTURE to support RAPIDS ( equal to ALL )( Dec 1, 2022
@robertmaynard robertmaynard self-assigned this Dec 8, 2022
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue Dec 8, 2022
@robertmaynard
rapids_cuda_init_architectures now supports "RAPIDS" value
da2162c 
Fixes rapidsai#314
@robertmaynard robertmaynard mentioned this issue Dec 13, 2022
Merged
4 tasks
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue Dec 19, 2022
@robertmaynard
rapids_cuda_init_architectures now supports "RAPIDS" value
8f1a4bc 
Fixes rapidsai#314
@rapids-bot rapids-bot bot closed this as completed in #327 Jan 4, 2023
rapids-bot bot pushed a commit that referenced this issue Jan 4, 2023
@robertmaynard
Fea/support cmake cuda architectures rapids value (#327)
49a9ced 
CMake 3.23+ now offers support for `all` and `all-major` as special keywords to `CMAKE_CUDA_ARCHITECTURES`. This means that rapids-cmake overload on `ALL` now creates confusion and breaks expectations ( trxcllnt/rapids-compose#84 https://gitlab.kitware.com/cmake/cmake/-/issues/23739, #104 ) 

This PR introduces the new magic keyword of `RAPIDS` which behaves the same as `ALL`, and will become the new apporved approach for projects that want to build for RAPIDS supported platforms.

Fixes #314


More details on the plans of deprecation for `ALL` can be found at: #318

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertmaynard robertmaynard

Labels
feature request New feature or request
Projects
rapids-cmake
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fea/support cmake cuda architectures rapids value robertmaynard/rapids-cmake
1 participant
@robertmaynard