Enable tracing of thread pool tasks using NVTX #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
2aca97e to
4efb3cf
Compare
| #define KVIKIO_NVTX_FUNC_RANGE_IMPL() NVTX3_FUNC_RANGE_IN(kvikio::libkvikio_domain) | ||
|
|
||
| // Implementation of KVIKIO_NVTX_SCOPED_RANGE(...) | ||
| #define KVIKIO_NVTX_SCOPED_RANGE_IMPL_3(message, payload_v, color) \ |
There was a problem hiding this comment.
I'm not sure why the variable has to be named payload_v. Otherwise payload would cause compile errors. Perhaps a name look-up related issue.
| @@ -192,7 +194,8 @@ std::future<std::size_t> FileHandle::pread(void* buf, | |||
| std::size_t gds_threshold, | |||
| bool sync_default_stream) | |||
| { | |||
| KVIKIO_NVTX_MARKER("FileHandle::pread()", size); | |||
| auto& [nvtx_color, call_idx] = detail::get_next_color_and_call_idx(); | |||
| KVIKIO_NVTX_SCOPED_RANGE("FileHandle::pread()", size, nvtx_color); | |||
There was a problem hiding this comment.
To be consistent with RemoteHandle, the NVTX marker here is replaced with the scoped range.
|
The following sample result shows the nsys profile generated using this PR. There are 4 worker threads in the thread pool, and I/O tasks of the same color come from the same
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the basic feature outlined in #631.
The two good-to-haves are currently blocked.