Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileHandle file resource may leak if the constructor throws an exception #607

Closed
kingcrimsontianyu opened this issue Jan 30, 2025 · 1 comment · Fixed by #614
Closed

FileHandle file resource may leak if the constructor throws an exception #607

kingcrimsontianyu opened this issue Jan 30, 2025 · 1 comment · Fixed by #614
Assignees
@kingcrimsontianyu
Labels
bug Something isn't working c++ Affects the C++ API of KvikIO

Comments

@kingcrimsontianyu
Copy link
Contributor

kingcrimsontianyu commented Jan 30, 2025 •
edited
Loading

The constructor of FileHandle may create the following resources:

  • File resource created by the system call open without the O_DIRECT flag.
  • File resource created by the system call open with the O_DIRECT flag.

There are two possibilities where the constructor may throw exceptions and cause trouble:

  • The compatibility mode is set to OFF but the file cannot be opened with the O_DIRECT flag.
  • The compatibility mode is set to OFF but the cuFileHandleRegister fails, for instance, due to unsupported or misconfigured system for cuFile I/O.

When the constructor throws, the destructor will not be called, resulting in resource leak. This issue can be fixed by using an RAII file resource manager.
@kingcrimsontianyu kingcrimsontianyu added the c++ Affects the C++ API of KvikIO label Jan 30, 2025
@madsbk madsbk added the bug Something isn't working label Jan 31, 2025
@kingcrimsontianyu kingcrimsontianyu mentioned this issue Jan 31, 2025
Open
@kingcrimsontianyu kingcrimsontianyu self-assigned this Feb 1, 2025
@kingcrimsontianyu kingcrimsontianyu mentioned this issue Feb 4, 2025
Merged
rapids-bot bot pushed a commit that referenced this issue Feb 4, 2025
@kingcrimsontianyu
Add RAII file wrappers to avoid resource leak (#614)
255ed48 
Closes #607

Authors:
  - Tianyu Liu (https://github.com/kingcrimsontianyu)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #614
@kingcrimsontianyu
Copy link
Contributor Author

This issue has been resolved with #614 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
bug Something isn't working c++ Affects the C++ API of KvikIO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RAII file wrappers to avoid resource leak kingcrimsontianyu/kvikio
2 participants
@madsbk @kingcrimsontianyu